D25043: [ResultDelegate] Use theme.disabledColor
Noah Davis
noreply at phabricator.kde.org
Tue Oct 29 19:57:10 GMT 2019
ndavis added a comment.
In D25043#555976 <https://phabricator.kde.org/D25043#555976>, @filipf wrote:
> Not a fan of this for 2 reasons:
>
> - we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: F7685168: Screenshot_20191029_141614.png <https://phabricator.kde.org/F7685168>
> - it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is 0.6 and not 0.5 or 0.3, so it seems that was wrong here).
>
> I'd just raise the opacity values instead.
Wait, this is the Breeze Dark colorscheme with the Breeze desktop theme? The desktop theme that gets its colors from the system colorscheme? If so, something is seriously wrong here.
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D25043
To: broulik, #plasma, #vdg, davidedmundson
Cc: ndavis, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191029/6c0ce602/attachment-0001.html>
More information about the Plasma-devel
mailing list