D24853: [DigitalClock] Fix layout and QML warnings

Konrad Materka noreply at phabricator.kde.org
Fri Oct 25 14:03:49 BST 2019


kmaterka added inline comments.

INLINE COMMENTS

> ngraham wrote in configTimeZones.qml:58
> Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing`

I just copied values form the original Rectangle. I will remove it entirely, probably it's not needed anymore.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191025/fc815235/attachment.html>


More information about the Plasma-devel mailing list