D24853: [DigitalClock] Fix layout and QML warnings

Nathaniel Graham noreply at phabricator.kde.org
Thu Oct 24 16:27:56 BST 2019


ngraham added a comment.


  Fair enough, that seems reasonable.

INLINE COMMENTS

> configTimeZones.qml:58
> +        Layout.fillWidth: true
> +        Layout.margins: 1
>  

Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/6929fcba/attachment.html>


More information about the Plasma-devel mailing list