D24846: Port kcm icons to kconfigxt

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> broulik wrote in main.cpp:141
> Does this `KIconTheme` instance need caching? I recall creating those parses a tonne of files and directories and is quite slow

Agreed, it'll hit the disk quite a bit, this might be a problem in a function which takes part in bindings (more than one which will change around the same time).

> main.cpp:176
> +{
> +       return m_model->selectedTheme() != KIconTheme::current();
> +}

Indentation looks wrong here.

> bport wrote in IconSizePopup.qml:47-53
> I wiil look if I can simplify that

I like the intent of trying to have names instead of just indices everywhere... but that might not be feasible without extra complexity we'll want to avoid indeed.

I think the more fundamental problem is that the settings are based on those names, while the invokables (most notably availableIconSizes) are based on indices. Probably something to address, like have names everywhere and just a function to map from index to name in the iconTypeList.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191025/269961df/attachment-0001.html>