D24846: Port kcm icons to kconfigxt

Benjamin Port noreply at phabricator.kde.org
Tue Oct 22 08:13:13 BST 2019


bport added inline comments.

INLINE COMMENTS

> broulik wrote in IconSizePopup.qml:45
> Do you not need to leave this (or a similar) connect in place?

This one is replaced (and that fix bug described above by call onVisibleChange)
and with kconfigxt property handling

> broulik wrote in IconSizePopup.qml:47-53
> I don't like this duplication, especially since sometimes you use `currentIndex` and sometimes the `currentCategory`

I wiil look if I can simplify that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/bf8c029b/attachment-0001.html>


More information about the Plasma-devel mailing list