D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in WallpaperFader.qml:145
> Why are we changing this line?

The clock shadow effectively renders the clock (shader effect with source hidden), so it has to be hidden.

> davidedmundson wrote in config.qml:21
> One thing Thomas always used to say was that if you have a checkbox it should be obvious what the opposite action is.
> 
> This currently sounds like if it's off, the clock will randomly start flashing like a 90's html <blink> tag.

Can I have a <marquee> clock?
"Show when idle"? (Open to non-jargon suggestions)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/e2253383/attachment.html>