D24893: [Lock Screen] Add option to hide clock when idle

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> WallpaperFader.qml:145
>                  target: clock.shadow
> -                opacity: 1
> +                opacity: wallpaperFader.alwaysShowClock ? 1 : 0
> +            }

Why are we changing this line?

> config.qml:21
> +            id: alwaysClock
> +            text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to show something", "Always show")
> +        }

One thing Thomas always used to say was that if you have a checkbox it should be obvious what the opposite action is.

This currently sounds like if it's off, the clock will randomly start flashing like a 90's html <blink> tag.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/90017721/attachment.html>