D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Oct 22 08:13:12 BST 2019


broulik added inline comments.

INLINE COMMENTS

> menu.cpp:146
> +                // Only show "Unlock Widgets" in the UI, not "Lock Widgets"
> +                if (!(name == QLatin1String("lock widgets") && c->corona()->immutability() == Plasma::Types::Mutable)) {
> +                    actions << a;

Please avoid negating entire boolean statements.

Instead of `!(foo && bar)` use `!foo || !bar`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/6b7e38f9/attachment.html>


More information about the Plasma-devel mailing list