<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24839">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24839#inline-140325">View Inline</a><span style="color: #4b4d51; font-weight: bold;">menu.cpp:146</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #74777d">// Only show "Unlock Widgets" in the UI, not "Lock Widgets"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"lock widgets"</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span class="n">c</span><span style="color: #aa2211">-></span><span class="n">corona</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">immutability</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">Mutable</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span class="n">a</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please avoid negating entire boolean statements.</p>

<p style="padding: 0; margin: 8px;">Instead of <tt style="background: #ebebeb; font-size: 13px;">!(foo && bar)</tt> use <tt style="background: #ebebeb; font-size: 13px;">!foo || !bar</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D24839</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24839">https://phabricator.kde.org/D24839</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, ngraham, mart<br /><strong>Cc: </strong>broulik, mart, ngraham, VDG, plasma-devel, Plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra<br /></div>