D24740: [Media Controller] Multiple artists support

[Denis Sheremet]

lesf0 added a comment.


  > Do you have commit access? If not, I need an E-Mail address so I can land this for you.
  
  I don't, you can add my email: me at lxlz.space
  
  > Bonus points if you also look at media controls in task manager (the ones when you hover a window): https://cgit.kde.org/plasma-desktop.git/tree/applets/taskmanager/package/contents/ui/ToolTipInstance.qml#n70
  >  and the lock screen https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MediaControls.qml#n73 :)
  
  I can add the same path, but I don't really use those components so I'm not sure if I can test those properly.

INLINE COMMENTS

> broulik wrote in main.qml:61
> Perhaps this should be turned around to check `Array.isArray(xesamArtist)` and in doubt have it cast to string?

That would make much more sence, but (at least for now) `QStringList` is array-like object and not an actual `Array` instance, and I don't really feel like I want to mess with all those "is-arrayish <https://www.npmjs.com/package/is-arrayish>" javascript stuff. Strings are way easier to check.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/8f9c9377/attachment.html>