D24740: [Media Controller] Multiple artists support

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks for your patch!
  I am not sure if the property should be perhaps changed to a `property var` and always contain an `Array`. But that would mean changing the tooltip, full representation, among other things.
  I think this is fine.
  Do you have commit access? If not, I need an E-Mail address so I can land this for you

INLINE COMMENTS

> main.qml:61
> +
> +        if (typeof xesamArtist == "string") {
> +            return xesamArtist

Perhaps this should be turned around to check `Array.isArray(xesamArtist)` and in doubt have it cast to string?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/b4adf38e/attachment-0001.html>