D24735: Gracefully replace outputModel

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  In D24735#549048 <https://phabricator.kde.org/D24735#549048>, @broulik wrote:
  
  > I call `release()` instead of `get()` so I reset the pointer to null so that when I signal `outputModelChanged` it returns `null` and QtQuick resets everything and only then I delete it.
  
  
  Ok, this comment explains why you do it this way. An important detail for understanding what's happening is the early return of `KCMKScreen::outputModel()`, where null is returned in case there is no `m_config`. Please reformulate the comment in the code so it's more easy to understand what's going on. Thanks for the fix!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/94c1d409/attachment.html>