<table><tr><td style="">romangg accepted this revision.<br />romangg added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24735">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D24735#549048" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24735#549048</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I call <tt style="background: #ebebeb; font-size: 13px;">release()</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">get()</tt> so I reset the pointer to null so that when I signal <tt style="background: #ebebeb; font-size: 13px;">outputModelChanged</tt> it returns <tt style="background: #ebebeb; font-size: 13px;">null</tt> and QtQuick resets everything and only then I delete it.</p></div>
</blockquote>
<p>Ok, this comment explains why you do it this way. An important detail for understanding what's happening is the early return of <tt style="background: #ebebeb; font-size: 13px;">KCMKScreen::outputModel()</tt>, where null is returned in case there is no <tt style="background: #ebebeb; font-size: 13px;">m_config</tt>. Please reformulate the comment in the code so it's more easy to understand what's going on. Thanks for the fix!</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24735">https://phabricator.kde.org/D24735</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, romangg, davidedmundson<br /><strong>Cc: </strong>ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>