D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, romangg, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This patch has it signal the disappearance of the `outputModel` and only then deletes it.
  This gives the QML side of things a chance to clean up, specifically `QQuickComboBox` stores the model in a `QVariant` and crashes if you just delete its backing model.

TEST PLAN
  QQC2 ComboBox should probably be fixed to store it in a `QPointer` or something but this at least fixes the crash.
  Opened KScreen KCM, changed something, hit "Reset", no crash

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

AFFECTED FILES
  kcm/kcm.cpp

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/03c72080/attachment-0001.html>