<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, romangg, davidedmundson.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24735">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch has it signal the disappearance of the <tt style="background: #ebebeb; font-size: 13px;">outputModel</tt> and only then deletes it.<br />
This gives the QML side of things a chance to clean up, specifically <tt style="background: #ebebeb; font-size: 13px;">QQuickComboBox</tt> stores the model in a <tt style="background: #ebebeb; font-size: 13px;">QVariant</tt> and crashes if you just delete its backing model.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>QQC2 ComboBox should probably be fixed to store it in a <tt style="background: #ebebeb; font-size: 13px;">QPointer</tt> or something but this at least fixes the crash.<br />
Opened KScreen KCM, changed something, hit "Reset", no crash</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24735">https://phabricator.kde.org/D24735</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcm/kcm.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, romangg, davidedmundson<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>