D24224: Start of the accessibility KCM

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmaccess.cpp:171
> +
> +    m_mouseSettings = new MouseSettings();
> +    m_keyboardSettings = new KeyboardSettings();

new MouseSettings(this)

in order to avoid memory leak (same for other settings)

> kcmaccess.cpp:179
> +    connect(m_screenReaderSettings, &ScreenReaderSettings::configChanged, this, [this]{ setNeedsSave(true); });
> +    connect(m_bellSettings, &BellSettings::configChanged, this, [this]{ setNeedsSave(true); });
> +

@ervin is working on fixing that (on KQuickAddons::ConfigModule) but unfortunatelly for now we need to connect all settings parameters to need save. When @ervin patch will be done we can remove that.
So I guess now if you are changing only one key the apply button is not updated to the good state

> CMakeLists.txt:24
>      KF5::KIOWidgets
> -    KF5::NewStuff
>      KF5::QuickAddons

Not sure why we have this change in this code review, seems unrelated

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191016/a562b57a/attachment.html>