<table><tr><td style="">bport requested changes to this revision.<br />bport added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24224">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24224#inline-139395">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmaccess.cpp:171</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_mouseSettings</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">MouseSettings</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_keyboardSettings</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KeyboardSettings</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">new MouseSettings(this)</p>
<p style="padding: 0; margin: 8px;">in order to avoid memory leak (same for other settings)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24224#inline-139397">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmaccess.cpp:179</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_screenReaderSettings</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">ScreenReaderSettings</span><span style="color: #aa2211">::</span><span class="n">configChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]{</span> <span class="n">setNeedsSave</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_bellSettings</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">BellSettings</span><span style="color: #aa2211">::</span><span class="n">configChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]{</span> <span class="n">setNeedsSave</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/ervin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ervin</a> is working on fixing that (on KQuickAddons::ConfigModule) but unfortunatelly for now we need to connect all settings parameters to need save. When <a href="https://phabricator.kde.org/p/ervin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ervin</a> patch will be done we can remove that.<br />
So I guess now if you are changing only one key the apply button is not updated to the good state</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24224#inline-139399">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> KF5::KIOWidgets
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> KF5::NewStuff
</div><div style="padding: 0 8px; margin: 0 4px; "> KF5::QuickAddons
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure why we have this change in this code review, seems unrelated</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24224">https://phabricator.kde.org/D24224</a></div></div><br /><div><strong>To: </strong>tcanabrava, ngraham, bport<br /><strong>Cc: </strong>broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra<br /></div>