D24529: [XembedSNIProxy] Check size in each update()
Konrad Materka
noreply at phabricator.kde.org
Thu Oct 10 13:07:26 BST 2019
kmaterka added inline comments.
INLINE COMMENTS
> davidedmundson wrote in sniproxy.cpp:217
> It's a bit weird to have a method called "getSomething" that changes the state of things
True, get* should not have side effect. I will change it.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24529
To: kmaterka, davidedmundson, #plasma, #plasma_workspaces, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191010/98c66e79/attachment.html>
More information about the Plasma-devel
mailing list