D24529: [XembedSNIProxy] Check size in each update()

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> sniproxy.cpp:217
>  
> +QSize SNIProxy::getClientWindowSize() const
> +{

It's a bit weird to have a method called "getSomething" that changes the state of things

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24529

To: kmaterka, davidedmundson, #plasma, #plasma_workspaces, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191010/fcc844a5/attachment.html>