D24514: [XembedSNIProxy] Do not crash on null pointer
Konrad Materka
noreply at phabricator.kde.org
Wed Oct 9 13:03:20 BST 2019
kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.
REVISION SUMMARY
XCB may return null pointer as a response. Add a check to prevent
segmentation fault.
BUG: 356937
TEST PLAN
It is hard to reproduce, but cause of the segmentation fault is pretty obvious thanks to debug dump from bug 409652
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24514
AFFECTED FILES
xembed-sni-proxy/fdoselectionmanager.cpp
xembed-sni-proxy/fdoselectionmanager.h
To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191009/3b08aaf2/attachment-0001.html>
More information about the Plasma-devel
mailing list