D24501: Use MenuItem's action property directly in ActionMenuItem

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Oct 8 15:17:18 BST 2019


apol added a comment.


  +1

INLINE COMMENTS

> ActionMenuItem.qml:26
>  
> -    property QtObject ourAction
> -
> -    text: ourAction.text
> -    visible: ourAction.visible !== undefined ? ourAction.visible : true
> -    enabled: ourAction.enabled
> -    checkable: ourAction.checkable
> -    checked: ourAction.checked
> +    visible: action.visible !== undefined ? action.visible : true
>      height: visible ? implicitHeight : 0

visible: action.visible === undefined || action.visible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24501

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/f30e8520/attachment.html>


More information about the Plasma-devel mailing list