D24501: Use MenuItem's action property directly in ActionMenuItem

Arjen Hiemstra noreply at phabricator.kde.org
Tue Oct 8 15:02:26 BST 2019


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Now that Kirigami's Action is a QQC2 Action subclass we can use
  MenuItem's action property directly, removing the need for custom
  bindings.
  
  This fixes Kirigami ActionMenus not showing keyboard shortcuts for
  actions, as that binding was missing.

TEST PLAN
  Applications' overflow menus and action submenus still work correctly.
  Menu items for actions that have keyboard shortcuts now display them.

REPOSITORY
  R169 Kirigami

BRANCH
  simpleactionmenuitem

REVISION DETAIL
  https://phabricator.kde.org/D24501

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionMenuItem.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/d2620061/attachment-0001.html>


More information about the Plasma-devel mailing list