D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: kossebau, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now windy conditions are not handled at all. I live in an area with very frequent
  windy conditions especially during certain times of year so this is annoying because I
  see the purple question mark icon a lot, which in the past has made me stop using the
  weather widget.
  
  This patch is an attempt to fix it for NOAA. It's not perfect because I don't know how to
  implement this for Wettercom, and we lack a  dedicated "windy conditions" Breeze icon,
  so I have re-used `weather-fog` for now. This is not ideal, but hopefully it's better
  than nothing. I have filed https://bugs.kde.org/show_bug.cgi?id=412718 to track getting
  a better icon.

TEST PLAN
  Before: F7543885: Before.png <https://phabricator.kde.org/F7543885>
  After: F7543886: After.png <https://phabricator.kde.org/F7543886>

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

AFFECTED FILES
  dataengines/weather/ions/ion.cpp
  dataengines/weather/ions/ion.h
  dataengines/weather/ions/noaa/ion_noaa.cpp

To: ngraham, kossebau, #plasma
Cc: plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/77da100f/attachment.html>