D25462: [Colors KCM] Use Kirigami.SearchField

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D25462#566149 <https://phabricator.kde.org/D25462#566149>, @aspotashev wrote:
  
  > The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900
  >
  > May be it's not time to adopt it yet?
  
  
  IMO, more like time to fix that bug. :) In the worst-case scenario, you can override `placeholderText` here and provide a translated string.
  
  However there is a deeper problem: now that System Settings uses a `SearchField` in its own toolbar, the Ctrl+F shortcut to trigger it becomes ambiguous. I guess we need to fix that too. However I see that this is already the case even without this patch, so there's no regression here at least.
  
  Therefore, +1.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25462

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191122/587fcfe4/attachment.html>