D25418: [Folder view] Use selected text color for selected items in full representation

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D25418#565427 <https://phabricator.kde.org/D25418#565427>, @ngraham wrote:
  
  > That was my first reaction in the bug report as well (see the discussion there). But try clicking on that file, not just highlighting it. :)
  
  
  I see. It seems like it's stuck halfway between looking like Kickoff and behaving like Dolphin. F7774899: Screenshot_20191120_170350.png <https://phabricator.kde.org/F7774899>
  
  If you make the text use the highlighted text color, we might have to undo that later on with the Breeze theme evolution. I'm not yet sure what the best way to differentiate selected list items and a hovered list items is.
  
  I suppose it wouldn't hurt to do this change now just to fix the bug though.

INLINE COMMENTS

> FolderItemDelegate.qml:354
> +                    color: frameLoader.textShadow && frameLoader.textShadow.visible
> +                        ? "#fff" : (model.selected ? PlasmaCore.ColorScope.highlightedTextColor : PlasmaCore.ColorScope.textColor)
>  

Is there not a better way to make nested if statements in QML?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-folderview-selected-text (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D25418

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191120/2851face/attachment-0001.html>