<table><tr><td style="">ndavis accepted this revision.<br />ndavis added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25418">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25418#565427" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25418#565427</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>That was my first reaction in the bug report as well (see the discussion there). But try clicking on that file, not just highlighting it. :)</p></div>
</blockquote>
<p>I see. It seems like it's stuck halfway between looking like Kickoff and behaving like Dolphin. <a href="https://phabricator.kde.org/F7774899" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7774899: Screenshot_20191120_170350.png</a></p>
<p>If you make the text use the highlighted text color, we might have to undo that later on with the Breeze theme evolution. I'm not yet sure what the best way to differentiate selected list items and a hovered list items is.</p>
<p>I suppose it wouldn't hurt to do this change now just to fix the bug though.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25418#inline-143685">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:354</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">frameLoader</span><span class="p">.</span><span style="color: #004012">textShadow</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">frameLoader</span><span class="p">.</span><span style="color: #004012">textShadow</span><span class="p">.</span><span style="color: #004012">visible</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211">?</span> <span style="color: #766510">"#fff"</span> <span style="color: #aa2211">:</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">frameLoader</span><span class="p">.</span><span style="color: #004012">textShadow</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">frameLoader</span><span class="p">.</span><span style="color: #004012">textShadow</span><span class="p">.</span><span style="color: #004012">visible</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">?</span> <span style="color: #766510">"#fff"</span> <span style="color: #aa2211">:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">model</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">selected</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">PlasmaCore.ColorScope.highlightedTextColor :</span></span><span class="bright"> </span><span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there not a better way to make nested if statements in QML?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-folderview-selected-text (branched from Plasma/5.17)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25418">https://phabricator.kde.org/D25418</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, ndavis<br /><strong>Cc: </strong>ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>