D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Noah Davis]

ndavis added a comment.


  In D25381#564512 <https://phabricator.kde.org/D25381#564512>, @guoyunhe wrote:
  
  > In D25381#564404 <https://phabricator.kde.org/D25381#564404>, @ndavis wrote:
  >
  > > If we do make flat toolbuttons buttons (`autoRaise == true`) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have a ton of UI regressions. Any non-flat button with a fixed icon size is going to have a regression. Anyone who was using non-flat buttons with 22px icons to get a bigger clickable area will need to switch to 32px icons. This also means that breeze-icons' problem with 32px icon style consistency will show itself more often.
  >
  >
  > Thanks for the remind!
  >
  > By default, QToolButton with 22px icons look good:
  >
  > F7771214: image.png <https://phabricator.kde.org/F7771214>
  >
  > When change to 32px, still okay:
  >
  > F7771218: image.png <https://phabricator.kde.org/F7771218>
  >
  > Maybe this is because Dolphin has all icons in 32px. Do you know any application that miss 32px icons in toolbar? Thanks!
  
  
  This issue is most likely to show up in 3rd party apps. Maybe we shouldn't let an issue like that dictate the design of Breeze widgets though since I expect either Breeze icons or the XDG icon specs will change one day to fix that issue. For now, I think we should stick to reducing the size of non-flat buttons or increasing the size of comboboxes and line edits. If we make non-flat button sizes match flat button sizes, we should do that in another patch.
  
  I personally think the height of line edits and comboboxes should be increased to 32px. This also makes it so we won't have to change how flat button sizes work if/when the non-flat buttons are made to match them.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191119/28afa48d/attachment.html>