D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

Filip Fila noreply at phabricator.kde.org
Mon Nov 18 17:45:45 GMT 2019


filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This is a fix for D25043 <https://phabricator.kde.org/D25043>.
  
  Using disabledTextColor results in bad text legibility with Plasma themes that use filled-style highlight effects.
  
  If colors are prefered over opacity as means of achieving text shading then we need to mix disabledTextColor with textColor on selection.
  
  This creates an effect that is comparable to the opacity: isCurrent? 0.8 : 0.6 code that is used throughout Plasma for subtitles.

REPOSITORY
  R112 Milou

BRANCH
  fix-bad-text-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25374

AFFECTED FILES
  lib/qml/ResultDelegate.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191118/d1ae7469/attachment-0001.html>


More information about the Plasma-devel mailing list