<table><tr><td style="">filipf created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />filipf requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25374">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This is a fix for <a href="https://phabricator.kde.org/D25043" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D25043</a>.</p>
<p>Using disabledTextColor results in bad text legibility with Plasma themes that use filled-style highlight effects.</p>
<p>If colors are prefered over opacity as means of achieving text shading then we need to mix disabledTextColor with textColor on selection.</p>
<p>This creates an effect that is comparable to the opacity: isCurrent? 0.8 : 0.6 code that is used throughout Plasma for subtitles.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 Milou</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-bad-text-legibility (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25374">https://phabricator.kde.org/D25374</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>lib/qml/ResultDelegate.qml</div></div></div><br /><div><strong>To: </strong>filipf<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>