D25363: Fix one more buffer overread in ksysguard network helper

Fabian Vogt noreply at phabricator.kde.org
Mon Nov 18 09:46:21 GMT 2019


fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.
  
  The `Packet` constructor has both `dataLength` and `packetSize` parameters, which are equal to the pcap header's `caplen` and `len`, respectively, and only the former specifies how much data is actually available in the buffer.
  So the comparison has to use `dataLength`, like the code below.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25363

To: maltek, ahiemstra, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191118/d59d5eb4/attachment.html>


More information about the Plasma-devel mailing list