<table><tr><td style="">fvogt requested changes to this revision.<br />fvogt added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25363">View Revision</a></tr></table><br /><div><div><p>I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.</p>
<p>The <tt style="background: #ebebeb; font-size: 13px;">Packet</tt> constructor has both <tt style="background: #ebebeb; font-size: 13px;">dataLength</tt> and <tt style="background: #ebebeb; font-size: 13px;">packetSize</tt> parameters, which are equal to the pcap header's <tt style="background: #ebebeb; font-size: 13px;">caplen</tt> and <tt style="background: #ebebeb; font-size: 13px;">len</tt>, respectively, and only the former specifies how much data is actually available in the buffer.<br />
So the comparison has to use <tt style="background: #ebebeb; font-size: 13px;">dataLength</tt>, like the code below.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R106 KSysguard</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25363">https://phabricator.kde.org/D25363</a></div></div><br /><div><strong>To: </strong>maltek, ahiemstra, fvogt<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>