D24706: [RFC] Change button style

[Nathaniel Graham]

ngraham added a comment.


  In D24706#562797 <https://phabricator.kde.org/D24706#562797>, @ndavis wrote:
  
  > How is it for you compared to the git master focus decorations? I know it's not what you're asking, but I'd like to know.
  
  
  Almost perfect except for I'd like the focus outline to be 2px thick (1px is too hard to notice, as you point out) and default buttons still have a background color that makes them too hard to notice IMO.
  
  > Things I've discovered about default buttons:
  > 
  > - The default button stops being the default button if you focus a pushbutton or combobox. In that case, nothing happens when you press [Enter]. It may be unrelated to the Breeze QStyle, but I think this should change so that the default button is always activated when [Enter] is pressed.
  > - GNOME's idea of a default button is effectively just the button which is focused by default. On one hand, there's no way to tell that [Enter] and [Space] trigger different actions, partly based on what is focused in Qt applications. On the other hand, knowing that you can press [Enter] to accept changes in a settings window without tabbing to the OK button (unless you focus a pushbutton or combobox) makes using settings windows feel a lot smoother for keyboard users.
  > - GNOME's behavior would work perfectly with what I wanted and eliminate the need to come up with a better default button indicator
  > - I think what we have is better in the long run for keyboard focused users if we can get it to work more consistently.
  
  I agree on both counts: that the GNOME approach is simpler and more immediately comprehensible, while our approach is more useful with real-world workflows, but slightly confusing in the subtlety of its behaviors. FWIW macOS does it largely the same way: enter triggers the default button, if there is one. Space triggers the focused thing, if it's different from the default button. Otherwise, both do the same thing. I guess it's not so weird to me since I got used to it over a lifetime of using macOS. The fact that the default button loses its default button status when a different pushbutton gets focus is the only difference between the Qt and macOS behaviors, and maybe something we could fix in Qt.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191115/39dbab81/attachment-0001.html>