<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24706">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D24706#562797" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24706#562797</a>, <a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>How is it for you compared to the git master focus decorations? I know it's not what you're asking, but I'd like to know.</p></div>
</blockquote>
<p>Almost perfect except for I'd like the focus outline to be 2px thick (1px is too hard to notice, as you point out) and default buttons still have a background color that makes them too hard to notice IMO.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Things I've discovered about default buttons:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The default button stops being the default button if you focus a pushbutton or combobox. In that case, nothing happens when you press <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Enter</kbd>. It may be unrelated to the Breeze QStyle, but I think this should change so that the default button is always activated when <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Enter</kbd> is pressed.</li>
<li class="remarkup-list-item">GNOME's idea of a default button is effectively just the button which is focused by default. On one hand, there's no way to tell that <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Enter</kbd> and <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Space</kbd> trigger different actions, partly based on what is focused in Qt applications. On the other hand, knowing that you can press <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Enter</kbd> to accept changes in a settings window without tabbing to the OK button (unless you focus a pushbutton or combobox) makes using settings windows feel a lot smoother for keyboard users.</li>
<li class="remarkup-list-item">GNOME's behavior would work perfectly with what I wanted and eliminate the need to come up with a better default button indicator</li>
<li class="remarkup-list-item">I think what we have is better in the long run for keyboard focused users if we can get it to work more consistently.</li>
</ul></blockquote>
<p>I agree on both counts: that the GNOME approach is simpler and more immediately comprehensible, while our approach is more useful with real-world workflows, but slightly confusing in the subtlety of its behaviors. FWIW macOS does it largely the same way: enter triggers the default button, if there is one. Space triggers the focused thing, if it's different from the default button. Otherwise, both do the same thing. I guess it's not so weird to me since I got used to it over a lifetime of using macOS. The fact that the default button loses its default button status when a different pushbutton gets focus is the only difference between the Qt and macOS behaviors, and maybe something we could fix in Qt.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24706">https://phabricator.kde.org/D24706</a></div></div><br /><div><strong>To: </strong>ndavis, VDG, Breeze<br /><strong>Cc: </strong>bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart<br /></div>