D25319: Fix issues from D24798 comments by @davidedmundson

David Edmundson noreply at phabricator.kde.org
Fri Nov 15 09:31:37 GMT 2019


davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigGeneral.qml:134
>                  var seconds = value / 1000
> -                return i18n("%1 seconds", seconds.toFixed(1))
> +                return i18nc("SpinBox text", "%1 seconds", seconds.toFixed(1))
>              }

The important part was the

I18np that handles "1 second" Vs "2 secondS"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25319

To: guoyunhe, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191115/3d668820/attachment.html>


More information about the Plasma-devel mailing list