<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25319">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25319#inline-142952">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">var</span> <span style="color: #004012">seconds</span> <span style="color: #aa2211">=</span> <span style="color: #004012">value</span> <span style="color: #aa2211">/</span> <span style="color: #601200">1000</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">return</span> <span style="color: #004012">i18n<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"%1 seconds"</span><span class="p">,</span> <span style="color: #004012">seconds</span><span class="p">.</span><span style="color: #004012">toFixed</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span style="color: #004012">i18n<span class="bright">c</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"SpinBox text"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510">"%1 seconds"</span><span class="p">,</span> <span style="color: #004012">seconds</span><span class="p">.</span><span style="color: #004012">toFixed</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The important part was the</p>

<p style="padding: 0; margin: 8px;">I18np that handles "1 second" Vs "2 secondS"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25319">https://phabricator.kde.org/D25319</a></div></div><br /><div><strong>To: </strong>guoyunhe, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>