D24798: Migrate QQC1 to QQC2

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> configTimeZones.qml:21-22
>  
> -import QtQuick 2.0
> -import QtQuick.Controls 1.2 as QtControls
> +import QtQuick 2.13
> +import QtQuick.Controls 2.13 as QQC2
>  import QtQuick.Layouts 1.0

Next plasma release can only depend on Qt 5.12

Please can you change accordingly

> ConfigGeneral.qml:134
> +                var seconds = value / 1000
> +                return i18n("%1 seconds", seconds.toFixed(1))
> +            }

Please keep this the same as before

i18ncp("Suffix for spinbox (seconds)", "second", "%1 secconds", seconds.toFixed(1));

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: davidedmundson, GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/b1a218bf/attachment.html>