<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24798">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24798#inline-142905">View Inline</a><span style="color: #4b4d51; font-weight: bold;">configTimeZones.qml:21-22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.<span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1.2</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">tControls</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.<span class="bright">13</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2.13</span></span> <span style="color: #004012">as</span> <span style="color: #004012">Q<span class="bright">QC2</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Layouts</span> <span style="color: #601200">1.0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Next plasma release can only depend on Qt 5.12</p>

<p style="padding: 0; margin: 8px;">Please can you change accordingly</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24798#inline-142906">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">var</span> <span style="color: #004012">seconds</span> <span style="color: #aa2211">=</span> <span style="color: #004012">value</span> <span style="color: #aa2211">/</span> <span style="color: #601200">1000</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"%1 seconds"</span><span class="p">,</span> <span style="color: #004012">seconds</span><span class="p">.</span><span style="color: #004012">toFixed</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please keep this the same as before</p>

<p style="padding: 0; margin: 8px;">i18ncp("Suffix for spinbox (seconds)", "second", "%1 secconds", seconds.toFixed(1));</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24798">https://phabricator.kde.org/D24798</a></div></div><br /><div><strong>To: </strong>guoyunhe, Plasma, Plasma: Workspaces, ngraham<br /><strong>Cc: </strong>davidedmundson, GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>