D25309: [Notifications KCM] Fix keyboard navigation in apps list
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Nov 14 18:00:14 GMT 2019
broulik added inline comments.
INLINE COMMENTS
> SourcesPage.qml:147
> id: sourceDelegate
> + focus: true
> width: sourcesList.width
Why this?
> SourcesPage.qml:153
> + sourcesList.forceActiveFocus();
> var sourceIdx = kcm.filteredModel.mapToSource(kcm.filteredModel.index(index, 0));
> appConfiguration.rootIndex = kcm.sourcesModel.makePersistentModelIndex(sourceIdx);
Can you try avoiding this code duplication? Does setting the `currentIndex` of the `ListView` here work?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25309
To: ngraham, broulik, #plasma
Cc: plasma-devel, guoyunhe, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191114/f5ce444f/attachment.html>
More information about the Plasma-devel
mailing list