<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25309">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25309#inline-142891">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SourcesPage.qml:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                        <span style="color: #aa4000">id: sourceDelegate</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">focus:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                        <span style="color: #aa4000">width:</span> <span style="color: #004012">sourcesList</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why this?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25309#inline-142890">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SourcesPage.qml:153</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span style="color: #004012">sourcesList</span><span class="p">.</span><span style="color: #004012">forceActiveFocus</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                            <span style="color: #aa4000">var</span> <span style="color: #004012">sourceIdx</span> <span style="color: #aa2211">=</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">filteredModel</span><span class="p">.</span><span style="color: #004012">mapToSource</span><span class="p">(</span><span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">filteredModel</span><span class="p">.</span><span style="color: #004012">index</span><span class="p">(</span><span style="color: #004012">index</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                            <span style="color: #004012">appConfiguration</span><span class="p">.</span><span style="color: #004012">rootIndex</span> <span style="color: #aa2211">=</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">sourcesModel</span><span class="p">.</span><span style="color: #004012">makePersistentModelIndex</span><span class="p">(</span><span style="color: #004012">sourceIdx</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you try avoiding this code duplication? Does setting the <tt style="background: #ebebeb; font-size: 13px;">currentIndex</tt> of the <tt style="background: #ebebeb; font-size: 13px;">ListView</tt> here work?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25309">https://phabricator.kde.org/D25309</a></div></div><br /><div><strong>To: </strong>ngraham, broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, guoyunhe, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>