D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

David Edmundson noreply at phabricator.kde.org
Mon Nov 11 15:43:55 GMT 2019


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QQC2 StackView has a major behavioural difference
  
  QQuickStackViewPrivate::setCurrentItem
  
    item->setFocus(true);
  
  This as a general rule makes sense, especially if you're pushing a whole
  focus scope onto the stackView, it would automatically select the right
  element. However as our base was not a focus scope the
  SessionManagementScreen instance itself got focus, taking it away from
  the child password box.
  
  LockScreenUi has to be changed so that it sets the initial focus the
  same even though the stackview is on QQC1.

TEST PLAN
  qmlscene in the sddm-theme directory with the dummydata setup
  locked the screen regularly
  
  Lots of gammaray

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25261

AFFECTED FILES
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191111/15f3e7c7/attachment-0001.html>


More information about the Plasma-devel mailing list