D25222: [Lock Screen] Fix album art binding loop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> MediaControls.qml:103
>              source: mpris2Source.albumArt
> -            sourceSize: Qt.size(width, height)
> +            sourceSize: Qt.size(paintedWidth, paintedHeight)
>              visible: status === Image.Loading || status === Image.Ready

We will display at a fixed height assigned from the layout and we adjust our item width to match the aspect ratio ourselves.

Therefore,  it only really makes sense to set a height on sourceSize
i.e  sourceSize.height: height

> If only one dimension of the size is set to greater than 0, the other dimension is set in proportion to preserve the source image's aspect ratio.

which is what we want

Image loads, we resize our width, but we won't re-evaluate this, so no loop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25222

To: filipf, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191110/63d9281b/attachment-0001.html>