<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25222">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25222#inline-142411">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MediaControls.qml:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">source:</span> <span style="color: #004012">mpris2Source</span><span class="p">.</span><span style="color: #004012">albumArt</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">sourceSize:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">w</span>idth</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">h</span>eight</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">sourceSize:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">paintedW</span>idth</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">paintedH</span>eight</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">visible:</span> <span style="color: #004012">status</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Image</span><span class="p">.</span><span style="color: #004012">Loading</span> <span style="color: #aa2211">||</span> <span style="color: #004012">status</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Image</span><span class="p">.</span><span style="color: #004012">Ready</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We will display at a fixed height assigned from the layout and we adjust our item width to match the aspect ratio ourselves.</p>

<p style="padding: 0; margin: 8px;">Therefore,  it only really makes sense to set a height on sourceSize<br />
i.e  sourceSize.height: height</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">If only one dimension of the size is set to greater than 0, the other dimension is set in proportion to preserve the source image's aspect ratio.</p></blockquote>

<p style="padding: 0; margin: 8px;">which is what we want</p>

<p style="padding: 0; margin: 8px;">Image loads, we resize our width, but we won't re-evaluate this, so no loop.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25222">https://phabricator.kde.org/D25222</a></div></div><br /><div><strong>To: </strong>filipf, davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>