D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Nov 7 10:56:05 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> ActionToolBar.qml:111
> +                visible: details.visibleActions.indexOf(modelData) != -1
> +                         && (modelData.visible !== undefined && modelData.visible)
> +

Shouldn't this be

  modelData.visible === undefined || modelData.visible

i.e. have the action show if `visible` is not defined

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25177

To: ahiemstra, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191107/acfc53e2/attachment.html>


More information about the Plasma-devel mailing list