D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

Arjen Hiemstra noreply at phabricator.kde.org
Wed Nov 6 18:41:48 GMT 2019


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This changes the layouting code in ActionToolBar to support reducing
  actions to IconOnly before hiding them for actions that have a
  displayHint set to KeepVisible. This mimics behaviour that is currently
  implemented in ToolBarHeader, where the main, left and right actions
  will be reduced to an icon-only version when the page gets below a
  certain width. The main difference in behaviour is that instead of
  switching all three actions at the same time, the actions will be
  switched one by one, which I feel makes more sense when using
  ActionToolBar standalone.
  
  Depends on D25176 <https://phabricator.kde.org/D25176>

TEST PLAN
  With Kirigami Gallery, on the misc widgets page, behaviour of the second toolbar
  is still the same.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_icononly

REVISION DETAIL
  https://phabricator.kde.org/D25177

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191106/c49e3294/attachment.html>


More information about the Plasma-devel mailing list