D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Currently the shortcuts are divided into two lists. "Application Launchers" for
  shortcuts added via .desktop files (actually components with names that end in
  ".desktop") and "Other Shortcuts" for everything else. This not only exposes an
  implementation detail but also is not helpful to the average user who doesn't
  know what is meant with "Application Launcher" is. It can't be about Applications
  since Konversation is found under "Other Shortcuts" but it is also not about
  launching since other shortcuts can also be found there (for example see
  Spectacle). Furthermore if one adds an shortcut to launch an application in
  kmenuedit the shortcut is not found in "Application Launchers" but in
  "Other Shortcuts" under KDE Daemon (addressed in D25086 <https://phabricator.kde.org/D25086>).
  This patch tries to categorize the components into Applications and Plasma by
  trying harder to get a corresponding `KService` and then deciding upon
  `isApplication` if a Component falls into the applications category. Because
  components are free to set their uniquea and friendly names themselves it is
  also checked if there is  a service with Name. With this it is possible to get a
  KService for konversation for example.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  categorize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25144

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191104/f53e6740/attachment-0001.html>