D25140: kcm/fonts: set initial settings correctly

Bhushan Shah noreply at phabricator.kde.org
Mon Nov 4 10:42:27 GMT 2019


bshah added a comment.


  > That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this:
  
  Important thing to note is, setSubPixelType doesn't actually write config. It just sets the internal configuration. Actual setting of value is done in FontAASettings::save.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191104/edc92d3d/attachment.html>


More information about the Plasma-devel mailing list