D25140: kcm/fonts: set initial settings correctly

[Fabian Vogt]

fvogt added a comment.


  That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this:
  
    KXftConfig::SubPixel::Type spType = KXftConfig::SubPixel::NotSet;
    // we get subpixel type from config
    xft.getSubPixelType(spType);
    m_originalState.subPixel = spType;
    if(spType == KXftConfig::SubPixel::NotSet) {
        spType = KXftConfig::SubPixel::Rgb;
    }
    
    setSubPixel(spType);

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191104/4b2d7d74/attachment.html>