D25043: [ResultDelegate] Use theme.disabledColor

[Filip Fila]

filipf added a comment.


  Ping.
  
  I don't think worsening text legibilty with some themes is a good feature for an LTS release.
  
  If this is going to get applied everywhere the effect will be magnified.
  
  Before (Arc Color theme and Breeze color scheme):
  F7720624: Screenshot_20191102_194243.png <https://phabricator.kde.org/F7720624>
  
  After (Arc Color theme and Breeze color scheme):
  F7720626: Screenshot_20191102_193934.png <https://phabricator.kde.org/F7720626>
  
  Before (McMojave theme):
  F7720659: Screenshot_20191102_194140.png <https://phabricator.kde.org/F7720659>
  
  After (McMojave theme):
  F7720662: Screenshot_20191102_194037.png <https://phabricator.kde.org/F7720662>
  
  I think what the screenshots actually show is this approach struggles a lot with filled-style highlight effects.
  
  I have a simple proposal: replace the `opacity: isCurrent? 0.8 : 0.6` hack with a color hack that would tint `disabledTextColor` with `textColor` if `isCurrent` is true.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D25043

To: broulik, #plasma, #vdg, davidedmundson
Cc: ndavis, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191102/bd453317/attachment.html>