<table><tr><td style="">filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25043">View Revision</a></tr></table><br /><div><div><p>Ping.</p>
<p>I don't think worsening text legibilty with some themes is a good feature for an LTS release.</p>
<p>If this is going to get applied everywhere the effect will be magnified.</p>
<p>Before (Arc Color theme and Breeze color scheme):<br />
<a href="https://phabricator.kde.org/F7720624" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7720624: Screenshot_20191102_194243.png</a></p>
<p>After (Arc Color theme and Breeze color scheme):<br />
<a href="https://phabricator.kde.org/F7720626" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7720626: Screenshot_20191102_193934.png</a></p>
<p>Before (McMojave theme):<br />
<a href="https://phabricator.kde.org/F7720659" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7720659: Screenshot_20191102_194140.png</a></p>
<p>After (McMojave theme):<br />
<a href="https://phabricator.kde.org/F7720662" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7720662: Screenshot_20191102_194037.png</a></p>
<p>I think what the screenshots actually show is this approach struggles a lot with filled-style highlight effects.</p>
<p>I have a simple proposal: replace the <tt style="background: #ebebeb; font-size: 13px;">opacity: isCurrent? 0.8 : 0.6</tt> hack with a color hack that would tint <tt style="background: #ebebeb; font-size: 13px;">disabledTextColor</tt> with <tt style="background: #ebebeb; font-size: 13px;">textColor</tt> if <tt style="background: #ebebeb; font-size: 13px;">isCurrent</tt> is true.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 Milou</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25043">https://phabricator.kde.org/D25043</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, davidedmundson<br /><strong>Cc: </strong>ndavis, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>