D21113: Allow hiding option items depending on available extension and version in the host

Fabian Vogt noreply at phabricator.kde.org
Mon May 27 12:55:13 BST 2019


fvogt added inline comments.

INLINE COMMENTS

> options.js:82
>  
> +function subsystemStatus() {
> +    return new Promise((resolve, reject) => {

AFAICT it doesn't conflict, but IMO it's a bit confusing if there's both a global array `subsystemStatus` in extension.js and a function `subsystemStatus()` in options.js.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21113

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190527/513ac454/attachment.html>


More information about the Plasma-devel mailing list